feat(substrait) Update to substrait v0.64.0 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
srikrishnak
commented
Jan 15, 2025
srikrishnak
commented
- Update proto definition to v0.64.0
- Fixed FetchRel to use OffsetMode and CountMode
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage ? 62.66%
=======================================
Files ? 44
Lines ? 10186
Branches ? 0
=======================================
Hits ? 6383
Misses ? 3517
Partials ? 286 ☔ View full report in Codecov by Sentry. |
* Update proto definition to v0.64.0 * Fixed FetchRel to use OffsetMode and CountMode
srikrishnak
force-pushed
the
substrait-go-proto
branch
from
913ff70 to
d944aa1
Compare
| @@ -411,10 +411,24 @@ func RelFromProto(rel *proto.Rel, reg expr.ExtensionRegistry) (Rel, error) { | |||
| return nil, fmt.Errorf("error getting input to FetchRel: %w", err) | |||
| } | |||
|
|
|||
| var offset int64 | |||
| if off, ok := rel.Fetch.OffsetMode.(*proto.FetchRel_Offset); ok { | |||
There was a problem hiding this comment.
It'd be useful to have tests that show we can work with both the new and old way of specifying FetchRel.
There was a problem hiding this comment.
@EpsilonPrime I wanted to defer adding the new way to a separate PR. This PR should be only update to new version and no change to functionality. Is that fine? Thanks
EpsilonPrime
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.