Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(substrait) Update to substrait v0.64.0 #105
feat(substrait) Update to substrait v0.64.0 #105
Changes from 1 commit
d944aa1
b0f2fa2
ff6ff7f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 600 in plan/builders.go
plan/builders.go#L591-L600
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be useful to have tests that show we can work with both the new and old way of specifying FetchRel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EpsilonPrime I wanted to defer adding the new way to a separate PR. This PR should be only update to new version and no change to functionality. Is that fine? Thanks
Check warning on line 419 in plan/plan.go
plan/plan.go#L418-L419
Check warning on line 426 in plan/plan.go
plan/plan.go#L425-L426
Check warning on line 384 in plan/relations.go
plan/relations.go#L383-L384
Check warning on line 394 in plan/relations.go
plan/relations.go#L394
Check warning on line 405 in plan/relations.go
plan/relations.go#L404-L405
Check warning on line 409 in plan/relations.go
plan/relations.go#L408-L409
Check warning on line 417 in plan/relations.go
plan/relations.go#L412-L417
Check warning on line 432 in plan/relations.go
plan/relations.go#L420-L432
Check warning on line 451 in plan/relations.go
plan/relations.go#L435-L451
Check warning on line 455 in plan/relations.go
plan/relations.go#L454-L455
Check warning on line 468 in plan/relations.go
plan/relations.go#L458-L468
Check warning on line 472 in plan/relations.go
plan/relations.go#L471-L472