FIXES ISSUE #4018 More default EDOs for temperament #4023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes the define temperament block's frequency selection from division to exponential format
walterbender
reviewed
Oct 4, 2024
| @@ -1774,9 +1774,11 @@ function TemperamentWidget() { | |||
| for (let i = 0; i < this.pitchNumber; i++) { | |||
| const idx = newStack.length; | |||
| if ( | |||
| this.inTemperament === "equal" || | |||
| (this.inTemperament === "equal" || this.inTemperament === "equal5" || | |||
There was a problem hiding this comment.
I forget how to do this in JS, but why not check to see that the first 5 letters are "equal" (begins with).
There was a problem hiding this comment.
@walterbender ohh so you want me to reduce it to check if the string starts with equal must follow the if otherwise else
|
Yes... it will be easier to read and maintain. |
|
@walterbender okay I'll make a new PR with desired changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after the addition of some new temperament the define frequency block used in the define temperament block uses the division approach to calculate the frequency instead as per the requirement we have to use the exponential of 2 format for more understanding.
temperament-test-2-2024-10-01_14.04.51.zip