Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXES ISSUE #4018 More default EDOs for temperament #4023

Closed
wants to merge 1 commit into from
Closed

FIXES ISSUE #4018 More default EDOs for temperament #4023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js/widgets/temperament.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,9 +1774,11 @@ function TemperamentWidget() {
for (let i = 0; i < this.pitchNumber; i++) {
const idx = newStack.length;
if (
this.inTemperament === "equal" ||
(this.inTemperament === "equal" || this.inTemperament === "equal5" ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget how to do this in JS, but why not check to see that the first 5 letters are "equal" (begins with).

Copy link
Contributor Author

@omsuneri omsuneri Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterbender ohh so you want me to reduce it to check if the string starts with equal must follow the if otherwise else

this.inTemperament === "equal7" || this.inTemperament === "equal19" ||
this.inTemperament === "equal31" ) ||
this.inTemperament === "1/3 comma meantone" ||
(this.typeOfEdit === "equal" && this.divisions === this.pitchNumber)
(this.typeOfEdit === "equal" && this.divisions === this.pitchNumber)
) {
newStack.push([
idx,
Expand Down
Loading