Skip to content

Conversation

@Deus1704
Copy link
Contributor

@Deus1704 Deus1704 commented Jun 11, 2024

Fixes #83
Fixes #103

Following our discussions, in this pr I've laid the skeleton for the new coalignment interface.
A basic use case is demonstrated, where the match_template method is registered by default. For details on the registration process, please refer to the code.

aia_map1 = sunpy.map.Map(sunpy.data.sample.AIA_193_CUTOUT01_IMAGE)
aia_map2 = sunpy.map.Map(sunpy.data.sample.AIA_193_CUTOUT03_IMAGE)
### Creating a template from aia_map1
bottom_left = SkyCoord(600 * u.arcsec, -500 * u.arcsec, frame=aia_map1.coordinate_frame)
top_right = SkyCoord(800 * u.arcsec, -200 * u.arcsec, frame=aia_map1.coordinate_frame)
submap = aia_map1.submap(bottom_left, top_right=top_right)

coaligned_map = coalignment(aia_map2, submap,"match_template")

Tasks:

  • Handle clipping
  • Deprecate existing API
  • Add tests
  • Add tests for checking the newly created functions
  • Add gallery examples for the new api
  • Write an exhaustive changelog
  • Decide on a better name for this method than "match_template"

@Deus1704 Deus1704 marked this pull request as draft June 11, 2024 14:43
@nabobalis

This comment was marked as outdated.

@Deus1704

This comment was marked as outdated.

@Deus1704 Deus1704 force-pushed the new_coalignment_api branch from 21d262d to bb4876a Compare June 12, 2024 17:34
@Deus1704

This comment was marked as outdated.

@nabobalis

This comment was marked as outdated.

@kreardon

This comment was marked as outdated.

@kreardon

This comment was marked as outdated.

@Deus1704

This comment was marked as outdated.

@nabobalis nabobalis changed the title new coalignment api (first draft) New Coalignment API Jun 14, 2024
@nabobalis

This comment was marked as outdated.

@kreardon

This comment was marked as outdated.

@nabobalis

This comment was marked as outdated.

@kreardon

This comment was marked as outdated.

@nabobalis

This comment was marked as outdated.

@nabobalis

This comment was marked as outdated.

@kreardon

This comment was marked as outdated.

@nabobalis nabobalis force-pushed the new_coalignment_api branch 6 times, most recently from cdff049 to 1f04351 Compare October 7, 2025 22:44
@nabobalis nabobalis force-pushed the new_coalignment_api branch 2 times, most recently from f0e6d29 to 179a810 Compare October 7, 2025 23:12
@nabobalis nabobalis force-pushed the new_coalignment_api branch from 179a810 to 286b3a3 Compare October 7, 2025 23:24
@nabobalis nabobalis requested a review from ayshih November 14, 2025 18:28
@nabobalis nabobalis mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a coalignment example to the gallery Refactor the coalignment module

6 participants