-
-
Notifications
You must be signed in to change notification settings - Fork 48
New Coalignment API #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Deus1704
wants to merge
95
commits into
sunpy:main
Choose a base branch
from
Deus1704:new_coalignment_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New Coalignment API #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
Jun 11, 2024
nabobalis
reviewed
Jun 11, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
21d262d to
bb4876a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nabobalis
reviewed
Jun 14, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nabobalis
reviewed
Jun 20, 2024
nabobalis
reviewed
Jun 20, 2024
nabobalis
reviewed
Jun 20, 2024
nabobalis
reviewed
Jun 20, 2024
nabobalis
reviewed
Jun 20, 2024
nabobalis
reviewed
Jun 20, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
wtbarnes
reviewed
Jul 10, 2025
nabobalis
reviewed
Jul 10, 2025
nabobalis
reviewed
Jul 10, 2025
nabobalis
reviewed
Jul 10, 2025
nabobalis
reviewed
Jul 10, 2025
nabobalis
reviewed
Jul 10, 2025
nabobalis
reviewed
Jul 10, 2025
nabobalis
reviewed
Jul 10, 2025
nabobalis
reviewed
Jul 17, 2025
cdff049 to
1f04351
Compare
f0e6d29 to
179a810
Compare
179a810 to
286b3a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Fixes #103
Following our discussions, in this pr I've laid the skeleton for the new coalignment interface.
A basic use case is demonstrated, where the match_template method is registered by default. For details on the registration process, please refer to the code.
Tasks: