fix: when resolving dep versions, it should respect versions in deno.lock #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyannyacha
force-pushed
the
ny/deno-lock
branch
2 times, most recently
from
dae4d95 to
3338408
Compare
nyannyacha
force-pushed
the
ny/deno-lock
branch
from
3859bb9 to
d7935dd
Compare
laktek
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Description
During the Deno 2 migration, an unintentionally missed exclamation mark caused dependency versions specified in deno.lock to not be respected by the graph creator, resulting in versions always being resolved to the latest remote version.
This PR fixes the issue.
Context: https://supabase.slack.com/archives/C02KMRX22NR/p1761124132389939?thread_ts=1761047631.883539&cid=C02KMRX22NR