Use mergeable symbols in embedded #8654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To workaround proper support for the Embedded Swift linkage model in SwiftPM, this PR updates the build plan to include -Xfrontend -mergeable symbols when building Embedded targets. This is a workaround/stop-gap solution until we can implement #8653. Fixes: 8648
rauhul
requested review from
bripeticca,
dschaefer2,
jakepetroules,
plemarquand and
shawnhyam
as code owners
rauhul
requested review from
bkhouri,
cmcgee1024,
daveyc123 and
owenv
as code owners
Member
Author
|
@swift-ci please test |
3 tasks
MaxDesiatov
pushed a commit
that referenced
this pull request
Jun 3, 2025
Contributor
|
@rauhul Recently, I've been seeing the following warning every time I build an Embedded Swift project. Is the Related PR: swiftlang/swift#84161 |
Contributor
|
IIUC it's no longer necessary, but I'm not sure if this change can be cleanly reverted, or is a different kind of cleanup needed |
Member
Author
|
We should be able to easily remove this flag now. |
Member
Author
Contributor
|
Thank you so much! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To workaround proper support for the Embedded Swift linkage model in SwiftPM, this PR updates the build plan to include -Xfrontend -mergeable symbols when building Embedded targets. This is a workaround/stop-gap solution until we can implement #8653.
Fixes: #8648