Skip to content

[IRGen] Use at least Int8 for extra tag bits #81151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Apr 28, 2025

rdar://149985633

Using at least Int8 here allows LLVM to apply more optimizations, reducing code size, avoiding stack allocations and as a result often eliminating complete stack frames.

@drexin drexin requested a review from rjmccall as a code owner April 28, 2025 22:11
@drexin drexin requested review from aschwaighofer and removed request for rjmccall April 28, 2025 22:12
@drexin drexin force-pushed the wip-149985633 branch 3 times, most recently from 6f5b4f0 to 20643eb Compare April 29, 2025 20:36
@drexin
Copy link
Contributor Author

drexin commented Apr 29, 2025

@swift-ci smoke test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no cursed way that this is ABI affecting. LGTM

@drexin
Copy link
Contributor Author

drexin commented Apr 30, 2025

@swift-ci smoke test

rdar://149985633

Using at least Int8 here allows LLVM to apply more optimizations, reducing code size, avoiding stack allocations and as a result often eliminating complete stack frames.
@drexin
Copy link
Contributor Author

drexin commented Apr 30, 2025

@swift-ci smoke test

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drexin
Copy link
Contributor Author

drexin commented May 1, 2025

@swift-ci smoke test linux

@drexin drexin merged commit 7634b82 into swiftlang:main May 1, 2025
3 checks passed
@drexin drexin deleted the wip-149985633 branch May 1, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants