Fix custom-logo favicon: update every icon link, not just the first#8
Open
KurtJacobson wants to merge 1 commit into
Open
Fix custom-logo favicon: update every icon link, not just the first#8KurtJacobson wants to merge 1 commit into
KurtJacobson wants to merge 1 commit into
Conversation
…irst index.html ships two icon links (svg + sizes=32x32) and browsers often prefer the sized one, so rewriting only the first link never visibly changed the tab icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the existing "use the custom logo as the favicon" behavior actually take effect. index.html declares two tags (an SVG one and a sizes="32x32" one), but use-site-config.tsx rewrote only the first match via querySelector. Browsers pick their preferred icon declaration — Chrome tends to prefer the one with explicit sizes — so the stock Keygate favicon kept winning and the tab icon never visibly changed.
The fix rewrites every matching link (querySelectorAll("link[rel~='icon']")) and leaves a comment explaining why, so it doesn't regress to the single-link form later.
Why?
Setting a custom logo_url in Settings → Branding is documented to also brand the browser tab, but in practice the favicon never changed — the update silently hit only the icon declaration the browser ignores. Discovered while self-hosting; confirmed by inspecting the live DOM (first link had the custom URL, second still pointed at /favicon.svg).
How to test
With no custom logo set, the stock favicon is untouched.
Checklist
go vet ./...passesgo test ./...passescd web && bun run build)