Skip to content

Fix custom-logo favicon: update every icon link, not just the first #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KurtJacobson wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

Fix custom-logo favicon: update every icon link, not just the first #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions web/src/hooks/use-site-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,15 @@ export function SiteConfigProvider({ children }: { children: ReactNode }) {
attribution_url: data.attribution_url || "https://keygate.app",
loading: false,
})
// Dynamic favicon from custom logo
// Dynamic favicon from custom logo. index.html declares
// multiple <link rel="icon"> variants and browsers pick their
// favorite (often the sizes="32x32" one), so rewriting only
// the first link never visibly changed the tab icon — update
// them all.
if (data.logo_url) {
const link = document.querySelector("link[rel='icon']") as HTMLLinkElement
if (link) link.href = data.logo_url
document.querySelectorAll<HTMLLinkElement>("link[rel~='icon']").forEach((link) => {
link.href = data.logo_url
})
}
if (data.brand_color) {
document.documentElement.style.setProperty("--color-primary", data.brand_color)
Expand Down