Import java.util.List when using nullable helpers #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR(s)! All looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I came across an issue where
java.util.Listis not imported forprivate static <T> @Nullable List<T> getList(@NonNull ResultSet rs, int col, Class<T[]> as) throws SQLException {This may have been missed during testing as the import is provided when queries return multiple results, as I discovered this on a query that had nullable values, but not multiple results.
I did think about adding this to https://github.com/tandemdude/sqlc-gen-java/blob/master/internal/codegen/queries.go#L129, as
java.util.Arraysis imported there, but I wasn't sure as it could result in unused imports. If you'd prefer it there, let me know.