Conversation
arai-a
reviewed
Nov 11, 2025
Contributor
arai-a
left a comment
arai-a
left a comment
There was a problem hiding this comment.
tested on SpiderMonkey, and one test fails
test/language/statements/using/initializer-disposed-at-end-of-switchstatement.js
Outdated
Show resolved
Hide resolved
rbuckton
force-pushed
the
explicit-resource-management-using
branch
from
233dd3d to
8b220d6
Compare
Contributor
Author
|
Thanks @arai-a, should be fixed now. |
Contributor
|
Since this has been reviewed by someone involved in the implementation, I would be comfortable to merge it now, to avoid holding it up any further. I personally won't have the bandwidth to get around to it in the near future. @gibson042 @ljharb @Ms2ger What do you think? |
ptomato
force-pushed
the
explicit-resource-management-using
branch
from
8b220d6 to
9289e81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to make review more manageable, this extracts the remaining tests specific to
usingstatement semantics from #3866