move token burn prep into the shares logic#63
Open
ethereumdegen wants to merge 1 commit intomerge-train-r4-testfrom
Open
move token burn prep into the shares logic#63ethereumdegen wants to merge 1 commit intomerge-train-r4-testfrom
ethereumdegen wants to merge 1 commit intomerge-train-r4-testfrom
Conversation
This was referenced Nov 25, 2024
Collaborator
Author
|
Approved by 0xAdri ok yeah, sorry I didn't completely understand before, got it now. Yes resetting the delay mappings is correct as it allows prevention of such attacks. Yes the current code then will mitigate both the flash loan issue and the resetting other user's delay mapping issue, it looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(NOTE: This update breaks storage slots )
Seeks to fix the issues described in Issues 60 and 61