chore(deps): update dependency mocha to v3 - #20
Merged
Merged
Conversation
Five spec files call CGI.unescape and none of them required cgi. It was
arriving transitively through mocha, which nothing declared and which
mocha 3 stopped doing, so the bump fails with 115 errors:
NameError: uninitialized constant CGI
spec/collections/containers_spec.rb:21
Requiring it in spec_helper covers the hand-written specs; the generated
conformance suite already emits its own require for the same reason.
This is the failure mode that took base64 out from under the library in
Ruby 3.4: a dependency nobody declared, supplied by something else, until
it wasn't.
Signed-off-by: Tim Smith <tim@mondoo.com>
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
"~> 2.1"→"~> 3.0"Release Notes
freerange/mocha (mocha)
v3.1.0Compare Source
v3.0.2Compare Source
v3.0.1Compare Source
v3.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.