Skip to content

chore(deps): update dependency mocha to v3 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tas50 merged 2 commits into from
Aug 24, 2026
Merged

chore(deps): update dependency mocha to v3 #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d76f74
chore(deps): update dependency mocha to v3
renovate[bot] Aug 24, 2026
2e6c648
test: require cgi explicitly, which mocha 3 no longer does for us
tas50 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ gemspec

group :test do
gem "minitest", "~> 5.20"
gem "mocha", "~> 2.1"
gem "mocha", "~> 3.0"
gem "rake", ">= 13.0"
gem "simplecov", require: false # opt-in via COVERAGE=1
end
Expand Down
8 changes: 8 additions & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@
end
end

# Specs read request bytes back through CGI.unescape. Required here rather than
# left to a transitive load: cgi was arriving via mocha, which nothing declared
# and which mocha 3 stopped doing -- turning a routine dependency bump into 115
# "uninitialized constant CGI" errors across five spec files.
#
# The generated conformance suite emits its own require for the same reason.
require "cgi"

require "minitest/autorun"
require "mocha/minitest"

Expand Down