Repository navigation
Turn TunerConstants into a dataclass - #360
Merged
Merged
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable new issues were found.
|
auscompgeek
force-pushed
the
tuner-swerve-dataclassify
branch
3 times, most recently
from
June 17, 2026 09:19
5a742d2 to
ecaa8e8
Compare
auscompgeek
force-pushed
the
tuner-swerve-dataclassify
branch
from
September 30, 2026 06:42
ecaa8e8 to
a4e65df
Compare
auscompgeek
force-pushed
the
tuner-swerve-dataclassify
branch
from
October 14, 2026 08:53
a4e65df to
61058cf
Compare
auscompgeek
force-pushed
the
tuner-swerve-dataclassify
branch
2 times, most recently
from
October 25, 2026 12:54
36cdc38 to
0c47861
Compare
This isn't in the corvus generated code.
Literally every other type checker is happy about my type alias...
auscompgeek
force-pushed
the
tuner-swerve-dataclassify
branch
from
November 8, 2026 03:32
d557166 to
01e6c55
Compare
LucienMorey
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it easy to switch between swerve constants for different drive bases. This provides a way to achieve #347 in a way that the type checker is actually happy with.
To make this easier to use, this also adds a script which will read the code generated by
corvus(either by the CLI tool or in Tuner X) and spit out a Python module with the appropriate constants.