Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system Puppet in CI #942

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented May 8, 2024

This uses the official Puppet AIO packages, which is also what we use in production. This makes the tests more realistic.

Currently just testing out if this even works.

@ekohl ekohl force-pushed the use-system-puppet-in-ci branch 3 times, most recently from 5e1c964 to 926140f Compare May 8, 2024 16:22
This uses the official Puppet AIO packages, which is also what we use in
production. This makes the tests more realistic.
@ekohl ekohl force-pushed the use-system-puppet-in-ci branch from 926140f to 8ee2f91 Compare May 8, 2024 16:26
run: |
. /etc/os-release
wget "https://apt.puppet.com/puppet${{ matrix.puppet }}-release-${VERSION_CODENAME}.deb"
sudo apt install "${PWD}/puppet${{ matrix.puppet }}-release-${VERSION_CODENAME}.deb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to do ./puppet...., apt refuses local installs from things that don't look like paths

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I added ${PWD}. I guess ./ would have also worked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, the race between typing a comment on mobile and forgetting to hit send and you pushing more changes :)

@ekohl
Copy link
Member Author

ekohl commented May 8, 2024

I think librarian isn't friendly with the AIO Puppet: cannot load such file -- concurrent. I suspect it doesn't properly purge the bundler environment variables (like we do in Kafo).

@ekohl
Copy link
Member Author

ekohl commented May 8, 2024

As I wrote somewhere else: I'm leaning to adding a step that builds the modules as separate from the others. Then store it in a cache and reuse it in the other axes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants