Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #37443 - find the right Edit button on the host details page #10298

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Refs #37443 - find the right Edit button on the host details page #10298

merged 1 commit into from
Aug 30, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Aug 29, 2024

Fixes: 37093a5

@evgeni evgeni mentioned this pull request Aug 29, 2024
Merged
@ekohl ekohl requested a review from MariaAga August 29, 2024 16:38
evgeni
evgeni commented Aug 30, 2024
View reviewed changes
test/integration/host_js_test.rb Outdated
@@ -529,6 +529,7 @@ class HostJSTest < IntegrationTestWithJavascript
page.find(id).click
assert page.has_no_selector?(id)
click_button('Submit')
find('h5', :text => host.fqdn) # wait for the host page to load
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dedicated click_on_submit helper (introduced in 1580adb), but all of its uses were removed in 98c1752 and I am not sure why.

Following the same logic as in 98c1752 and using a find to find the header with the hostname.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split that change out to #10302

@evgeni
Copy link
Member Author

evgeni commented Aug 30, 2024

#10298 and #10302 were tested together in #10125 and turn up green \o/

@evgeni evgeni mentioned this pull request Aug 30, 2024
Merged
MariaAga
MariaAga approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@MariaAga MariaAga merged commit 50ce6f1 into develop Aug 30, 2024
94 of 101 checks passed
@MariaAga MariaAga deleted the welp-click branch August 30, 2024 10:36
@evgeni evgeni mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaAga MariaAga MariaAga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeni @MariaAga