Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37774 - wait for the host page to render before editing again #10302

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fixes #37774 - wait for the host page to render before editing again #10302

merged 1 commit into from
Aug 30, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Aug 30, 2024

Fixes: fe5c585

@evgeni evgeni mentioned this pull request Aug 30, 2024
Merged
evgeni
evgeni commented Aug 30, 2024
View reviewed changes
test/integration/host_js_test.rb
Comment on lines 531 to +532
click_button('Submit')
find('h5', :text => host.fqdn) # wait for the host page to load
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dedicated click_on_submit helper (introduced in 1580adb), but all of its uses were removed in 98c1752 and I am not sure why.

Following the same logic as in 98c1752 and using a find to find the header with the hostname.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps assert page.has_link?('Edit') no longer worked?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk. Maybe. I just want #10125 to pass :D

@evgeni evgeni requested a review from MariaAga August 30, 2024 06:27
@evgeni
Copy link
Member Author

evgeni commented Aug 30, 2024

#10298 and #10302 were tested together in #10125 and turn up green \o/

MariaAga
MariaAga approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM, thank you!

@MariaAga MariaAga merged commit 2ea2c46 into develop Aug 30, 2024
47 of 52 checks passed
@MariaAga MariaAga deleted the i37774 branch August 30, 2024 10:41
@evgeni evgeni mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@MariaAga MariaAga MariaAga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ekohl @MariaAga