Handle comment reviews as a review #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many people just leave a comment instead of requesting changes. Today those are ignored, but it leaves the PR labels in an odd state. This starts treating comment reviews as being reviewed. It doesn't request changes on the author because it's unclear who needs to take action to move things forward. Link: https://community.theforeman.org/t/reviewing-prprocessors-review-labels/38844
dgoetz
approved these changes
Aug 2, 2024
ehelms
approved these changes
Aug 2, 2024
|
Found an edge case: I like to self-review with some TODOs and in theforeman/foreman#10227 (comment) you can see it also counts as a review. You can look at the reviewer relationship and that can probably be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people just leave a comment instead of requesting changes. Today those are ignored, but it leaves the PR labels in an odd state.
This starts treating comment reviews as being reviewed. It doesn't request changes on the author because it's unclear who needs to take action to move things forward.
This was discussed in https://community.theforeman.org/t/reviewing-prprocessors-review-labels/38844