Skip to content

Comments

Add @ludeeus ShellCheck GitHub Action#20

Open
atrepca wants to merge 3 commits intothomasfr:mainfrom
atrepca:shellcheck
Open

Add @ludeeus ShellCheck GitHub Action#20
atrepca wants to merge 3 commits intothomasfr:mainfrom
atrepca:shellcheck

Conversation

@atrepca
Copy link

@atrepca atrepca commented Oct 24, 2024

Reopened #6 with adding a GitHub action for ShellCheck.

Tested this with my fork and it works as expected:

./amazon-s3-backup/run.sh:17:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
./amazon-s3-backup/run.sh:18:8: warning: Declare and assign separately to avoid masking return values. [SC2155]

I excluded SC1008, the with-contenv shebang is appropriate for Docker even though ShellCheck doesn't like it.

@atrepca
Copy link
Author

atrepca commented Jan 15, 2025

Following up here @thomasfr, any chance this can get a review? Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant