Conversation
thomasfr
requested changes
Mar 30, 2023
Owner
thomasfr
left a comment
There was a problem hiding this comment.
Thank you very much. Did not know shellcheck tbh and was not aware of SC2155. So thanks for that.
If you or someone else interested in contributing, i would also accept a PR for enabling ShellCheck within Github Actions.
7539d1b to
780e9b4
Compare
Author
|
Going to close this and fix the ShellCheck errors in #20 so the action starts with a clean state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the script through the shellcheck static analysis tool returns the errors below:
SC2155 is detailed here, and SC1008 here.
ShellCheck can also run as a GitHub action.
Also removed the executable bit from other non-executables that had it.