Remove incorrect authid submission in callback - #18
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
This PR removes the cross-flow authId reuse in signUp (React and Vue clients). With backend call node support, self-signup runs within the same OAuth flow execution, so authId is available directly from the URL and the hybrid-storage fallback is no longer needed. The backend now also rejects assertions whose authorization_request_id claim doesn't match the callback's authId, so stale cached values would fail server-side anyway.
🔧 Summary of Breaking Changes
signUp no longer falls back to a previously stored authId — it only reads from the current URL.
💥 Impact
Consumers running this SDK against a backend that does not yet support the call node concept (where self-signup runs as a in-flow invocation) will see signUp complete without an authId, and the OAuth authorize request will not be completed.
🔄 Migration Guide
Upgrade the ThunderID backend to a version that supports call node based self-signup. No consumer code change is required.
Approach
Drop the getHybridDataParameter('authId') fallback read and setHybridDataParameter('authId', ...) write in signUp on both clients. signIn's handling of authId is unchanged. Existing cleanup calls (TokenCallback, sign-out) are retained.
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks