Skip to content

Remove incorrect authid submission in callback #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brionmario merged 1 commit into from
Jul 7, 2026
Merged

Remove incorrect authid submission in callback #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/react/src/ThunderIDReactClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,14 +224,7 @@ class ThunderIDReactClient<T extends ThunderIDReactConfig = ThunderIDReactConfig
const firstArg: any = args[0];
const baseUrl: string = config?.baseUrl ?? '';

const authIdFromUrl: string = new URL(window.location.href).searchParams.get('authId') ?? '';
const authIdFromStorage: string =
((await this.getStorageManager().getHybridDataParameter('authId')) as string) ?? '';
const authId: string = authIdFromUrl || authIdFromStorage;

if (authIdFromUrl && !authIdFromStorage) {
await this.getStorageManager().setHybridDataParameter('authId', authIdFromUrl);
}
const authId: string = new URL(window.location.href).searchParams.get('authId') ?? '';

const response: any = await executeEmbeddedSignUpFlow({
authId,
Expand Down
10 changes: 1 addition & 9 deletions packages/vue/src/ThunderIDVueClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,15 +254,7 @@ class ThunderIDVueClient<T extends ThunderIDVueConfig = ThunderIDVueConfig> exte
const firstArg: any = args[0];
const baseUrl: string = configData?.baseUrl || '';

const authIdFromUrl: string | null = new URL(window.location.href).searchParams.get('authId');
const authIdFromStorage: string | null = (await this.getStorageManager().getHybridDataParameter('authId')) as
| string
| null;
const authId: string = authIdFromUrl || authIdFromStorage || '';

if (authIdFromUrl && !authIdFromStorage) {
await this.getStorageManager().setHybridDataParameter('authId', authIdFromUrl);
}
const authId: string = new URL(window.location.href).searchParams.get('authId') ?? '';

const response: any = await executeEmbeddedSignUpFlow({
authId,
Expand Down
Loading