style: make three code comments timeless - #324
Merged
Merged
Conversation
Drop slice and ticket references from code comments so they read as durable rationale rather than progress notes: the KYC orchestrator no longer says the provider reference is unpersisted 'in this slice', the decision rule controller drops the 'later slice' idempotency aside, and the KYC context test no longer references a closed sandbox issue. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality sweep over the merged codebase to bring comments to a maximally senior, timeless form.
Audit result
The codebase is already clean (every slice passed the per-slice code-reviewer + code-simplifier anti-slop gate). Deterministic scans found: 0 em/en-dash in code, 0 TODO/FIXME/XXX/HACK, 0 'In this commit' phrasing. The only findings were three comments that referenced implementation slices or a closed ticket:
Comment-only, behaviour-preserving. compliance + decision compile, detekt and spotless green locally. The legitimate why-comments (invariants, tx-boundary notes, MapStruct-limitation and JSONB-normalization rationale, fail-closed/ReDoS reasoning) were deliberately kept - they earn their place.