Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ class KycApiContextIT(
class TestBeans {
@Bean fun jwtDecoder(): JwtDecoder = mockk()

// No in-tree KycProvider yet (sandbox is #239); a fake satisfies the orchestrator's dependency so the
// full web context boots.
// A fake KycProvider satisfies the orchestrator's dependency so the full web context boots in isolation.
@Bean fun kycProvider(): KycProvider =
object : KycProvider {
override fun check(request: KycCheckRequest): KycCheckResult = KycCheckResult.Pending("ref-test")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import org.springframework.stereotype.Service
*
* Concurrent process calls on the same session resolve via the entity's optimistic lock: the loser's
* OptimisticLockingFailureException propagates. Pending and InsufficientData leave the session in SCREENING (there is
* no PENDING status); a later re-screen advances it. The provider reference is not persisted in this slice.
* no PENDING status); a later re-screen advances it. The provider reference is not persisted.
*/
@Service
class KycOrchestrator(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class DecisionRuleController(
}

// No Idempotency-Key here by design: versions are append-only and monotonic, so a retried publish creates
// a new, immutable version rather than corrupting state. The full idempotency subsystem is a later slice.
// a new, immutable version rather than corrupting state.
@Operation(summary = "Publish a rule version", description = "Validates the DSL document and stores it as the new active version.")
@PostMapping("/{ruleKey}/versions", consumes = [MediaType.APPLICATION_JSON_VALUE])
fun publishVersion(
Expand Down
Loading