Wrap all access to h5 files in a lock#126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In #91 the hdf5 file access pattern was changed and the locking mechanism removed. This was done due to h5py's claim to be thread safe.
Problem Statement
Icon experienced sporadic SIGSEGV when a hdf5 file was read from multiple clients simultaneously. With GDB the SIGSEGV trigger could be localized to the hdf5 library
More details: h5py/h5py#2920
Solution Proposal
For now, we wrap the
h5_opencontext manager into a lock, such that hdf5 file access between threads in a process is serialized.