Skip to content

Wrap all access to h5 files in a lock #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beitler merged 2 commits into from
Jun 29, 2026
Merged

Wrap all access to h5 files in a lock #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32585f
Wrap all access to h5 files in a lock
beitler Jun 26, 2026
766045d
format
beitler Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/icon/server/data_access/repositories/experiment_data_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import json
import logging
import threading
import time
from collections.abc import Iterator
from contextlib import contextmanager
Expand Down Expand Up @@ -819,16 +820,19 @@ def get_result_channels_dataset(

POLL_INTERVAL = 0.05

_HDF5_GLOBAL_LOCK = threading.RLock()


@contextmanager
def h5_open(path: Path, mode: str, **kwargs: Any) -> Iterator[h5py.File]:
while True:
try:
with h5py.File(str(path), mode, **kwargs) as h5file:
yield h5file
break
except (OSError, FileNotFoundError):
time.sleep(POLL_INTERVAL)
with _HDF5_GLOBAL_LOCK:
while True:
try:
with h5py.File(str(path), mode, **kwargs) as h5file:
yield h5file
break
except (OSError, FileNotFoundError):
time.sleep(POLL_INTERVAL)


def _read_fits_from_hdf5(
Expand Down