round up reviewers payments #102
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| handle: reviewer.memberHandle, | ||
| userId: reviewer.memberId.toString(), | ||
| amount: Math.round( | ||
| amount: Math.ceil( |
There was a problem hiding this comment.
[❗❗ correctness]
Using Math.ceil instead of Math.round changes the behavior of the payment calculation by always rounding up. Ensure this change aligns with the intended business logic, as it could result in higher payments than previously calculated.
| // } | ||
| // }), | ||
| // ); | ||
| console.log('here3', payments); |
There was a problem hiding this comment.
[❗❗ correctness]
The commented-out code suggests that the logic for processing payments has been disabled. If this is intentional for testing or debugging, consider adding a clear explanation in the pull request description or commit message to avoid confusion for other developers. If this is not intentional, it could lead to missing payment processing functionality.
|
|
||
| this.logger.log('Task Completed. locking consumed budget', baValidation); | ||
| await this.baService.lockConsumeAmount(baValidation); | ||
| // await this.baService.lockConsumeAmount(baValidation); |
There was a problem hiding this comment.
[❗❗ correctness]
The commented-out line for locking the consumed budget suggests that this functionality is currently disabled. Ensure that this is intentional and documented, as it might affect budget management and lead to inconsistencies if left unchecked.
| // }), | ||
| // ); | ||
| console.log('here3', payments); | ||
|
|
There was a problem hiding this comment.
[performance]
Using console.log for debugging purposes in production code can lead to performance issues and cluttered logs. Consider using a proper logging mechanism that integrates with your existing logging strategy.
1 participant
No description provided.