Skip to content

round up reviewers payments #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

round up reviewers payments #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd9b090
round up reviewers payments
vas3a Oct 23, 2025
bd3a8b2
undo mixup
vas3a Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/api/challenges/challenges.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ export class ChallengesService {
challenge: Challenge,
reviewers: ChallengeResource[],
): Promise<PaymentPayload[]> {
// generate placement payments
const placementPrizes = orderBy(
find(challenge.prizeSets, { type: 'PLACEMENT' })?.prizes,
'value',
Expand Down Expand Up @@ -206,7 +205,7 @@ export class ChallengesService {
return {
handle: reviewer.memberHandle,
userId: reviewer.memberId.toString(),
amount: Math.round(
amount: Math.ceil(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Using Math.ceil instead of Math.round changes the behavior of the payment calculation by always rounding up. Ensure this change aligns with the intended business logic, as it could result in higher payments than previously calculated.

(challengeReviewer.fixedAmount ?? 0) +
(challengeReviewer.baseCoefficient ?? 0) * firstPlacePrize +
(challengeReviewer.incrementalCoefficient ?? 0) *
Expand Down