fix(PM-1169) Cancel all copilot requests when copilot added via WM #816
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -149,7 +149,7 @@ workflows: | |||
| context : org-global | |||
| filters: | |||
| branches: | |||
| only: ['develop', 'migration-setup', 'pm-1169'] | |||
| only: ['develop', 'migration-setup', 'pm-1169_1'] | |||
There was a problem hiding this comment.
The branch name has been changed from 'pm-1169' to 'pm-1169_1'. Ensure that this change is intentional and that all relevant documentation and references to the branch name are updated accordingly.
| }, { | ||
| where: { | ||
| copilotRequestId: { | ||
| [Op.in]: allCopilotOpportunityByRequestIds, |
There was a problem hiding this comment.
The where clause should use allCopilotOpportunityByRequestIds.map(item => item.id) instead of allCopilotOpportunityByRequestIds directly. This ensures that the condition is checking against the correct data type (array of IDs).
| @@ -170,6 +172,67 @@ module.exports = [ | |||
| }, { | |||
| transaction: t, | |||
| }); | |||
| } else if (source === INVITE_SOURCE.WORK_MANAGER) { | |||
| req.log.info("cancelling all existing requests", source); | |||
There was a problem hiding this comment.
Consider providing more context in the log message to make it clear what specific action is being taken. For example, include the project ID or other relevant identifiers to help with debugging.
| }); | ||
|
|
||
| const requestIds = allCopilotRequestsByProjectId.map(item => item.id); | ||
| req.log.info("requestIds", requestIds); |
There was a problem hiding this comment.
Consider removing or adjusting the log statement before merging. Logging sensitive information or excessive data can lead to performance issues or security concerns. If logging is necessary, ensure it is appropriately handled and does not expose sensitive information.
| transaction: t, | ||
| }); | ||
|
|
||
| req.log.info("allCopilotOpportunityByRequestIds", allCopilotOpportunityByRequestIds.length); |
There was a problem hiding this comment.
Consider using a more descriptive log message to provide context about the operation being logged. For example, include information about what the length represents or the significance of this log entry.
| transaction: t, | ||
| }); | ||
|
|
||
| req.log.info("updated CopilotApplication"); |
There was a problem hiding this comment.
Consider providing more context in the log message to make it clear what specific changes were made to the CopilotApplication. This can help in debugging and understanding the flow of the application.
| }, { | ||
| where: { | ||
| id: { | ||
| [Op.in]: allCopilotOpportunityByRequestIds.map(item => item.id), |
There was a problem hiding this comment.
The change from copilotRequestId to id suggests that allCopilotOpportunityByRequestIds is now an array of objects rather than an array of IDs. Ensure that allCopilotOpportunityByRequestIds is correctly populated with objects containing an id property before this line is executed.
| transaction: t, | ||
| }); | ||
|
|
||
| // Cancel the existing invites which are opened via |
There was a problem hiding this comment.
The comment on line 236 is unnecessary and should be removed. Comments should not be added to the code as per the instructions.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-1169