-
Notifications
You must be signed in to change notification settings - Fork 56
fix(PM-1169) Cancel all copilot requests when copilot added via WM #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
a282f0b
ff6f62a
0a3317a
aa5cc62
f7579a0
2065478
724d028
21b079b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
import validate from 'express-validation'; | ||
import _ from 'lodash'; | ||
import Joi from 'joi'; | ||
import { Op } from 'sequelize'; | ||
import { middleware as tcMiddleware } from 'tc-core-library-js'; | ||
import models from '../../models'; | ||
import util from '../../util'; | ||
import { INVITE_STATUS, EVENT, RESOURCES, COPILOT_APPLICATION_STATUS, COPILOT_OPPORTUNITY_STATUS, COPILOT_REQUEST_STATUS, INVITE_SOURCE } from '../../constants'; | ||
import { PERMISSION } from '../../permissions/constants'; | ||
|
||
|
||
/** | ||
* API to update invite member to project. | ||
* | ||
|
@@ -170,6 +172,67 @@ module.exports = [ | |
}, { | ||
transaction: t, | ||
}); | ||
} else if (source === INVITE_SOURCE.WORK_MANAGER) { | ||
req.log.info("cancelling all existing requests", source); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider providing more context in the log message to make it clear what specific action is being taken. For example, include the project ID or other relevant identifiers to help with debugging. |
||
const allCopilotRequestsByProjectId = await models.CopilotRequest.findAll({ | ||
where: { | ||
projectId: invite.projectId, | ||
}, | ||
transaction: t, | ||
}); | ||
|
||
const requestIds = allCopilotRequestsByProjectId.map(item => item.id); | ||
req.log.info("requestIds", requestIds); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider removing or adjusting the log statement before merging. Logging sensitive information or excessive data can lead to performance issues or security concerns. If logging is necessary, ensure it is appropriately handled and does not expose sensitive information. |
||
|
||
await models.CopilotRequest.update({ | ||
status: COPILOT_REQUEST_STATUS.CANCELED, | ||
}, { | ||
where: { | ||
id: { | ||
[Op.in]: requestIds, | ||
} | ||
}, | ||
transaction: t, | ||
}); | ||
|
||
req.log.info("updated copilot request"); | ||
|
||
const allCopilotOpportunityByRequestIds = await models.CopilotOpportunity.findAll({ | ||
where: { | ||
copilotRequestId: { | ||
[Op.in]: requestIds, | ||
}, | ||
}, | ||
transaction: t, | ||
}); | ||
|
||
req.log.info("allCopilotOpportunityByRequestIds", allCopilotOpportunityByRequestIds.length); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using a more descriptive log message to provide context about the operation being logged. For example, include information about what the length represents or the significance of this log entry. |
||
|
||
await models.CopilotOpportunity.update({ | ||
status: COPILOT_OPPORTUNITY_STATUS.CANCELED, | ||
}, { | ||
where: { | ||
copilotRequestId: { | ||
[Op.in]: allCopilotOpportunityByRequestIds, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
}, | ||
}, | ||
transaction: t, | ||
}); | ||
|
||
req.log.info("updated copilot opportunity"); | ||
|
||
await models.CopilotApplication.update({ | ||
status: COPILOT_APPLICATION_STATUS.CANCELED, | ||
}, { | ||
where: { | ||
opportunityId: { | ||
[Op.in]: allCopilotOpportunityByRequestIds.map(item => item.id), | ||
}, | ||
}, | ||
transaction: t, | ||
}); | ||
|
||
req.log.info("updated CopilotApplication"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider providing more context in the log message to make it clear what specific changes were made to the CopilotApplication. This can help in debugging and understanding the flow of the application. |
||
} | ||
|
||
await t.commit(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch name has been changed from 'pm-1169' to 'pm-1169_1'. Ensure that this change is intentional and that all relevant documentation and references to the branch name are updated accordingly.