Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bazzite should be detected as FedoraImmutable #1034

Closed
wants to merge 1 commit into from

Conversation

SteveLauC
Copy link
Member

What does this PR do

As titled, closes #1033

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@dtomvan
Copy link
Contributor

dtomvan commented Feb 16, 2025

In src/steps/os/linux.rs:65:

               match variant {
                   "Silverblue" | "Kinoite" | "Sericea" | "Onyx" | "IoT Edition" | "Sway Atomic" => {

Shouldn't VARIANT="Kinoite" inside of /etc/os-release already get detected without this PR?

Anyways, LGTM, but it could be useful to add cases for Aurora, Bluefin and uCore as well?

@dtomvan
Copy link
Contributor

dtomvan commented Feb 16, 2025

Correction:

Shouldn't VARIANT="Kinoite" inside of /etc/os-release already get detected without this PR?

They don't get picked up because they are behind a ID=fedora check, but on bazzite this is ID=bazzite. I'll try to fix the problem.

@dtomvan
Copy link
Contributor

dtomvan commented Feb 16, 2025

All right, decided to refactor it a bit because I am dealing with this issue too. Could you review my PR #1043? I included this commit too.

@SteveLauC
Copy link
Member Author

Close as this has been superseded by #1043

@SteveLauC SteveLauC closed this Feb 17, 2025
@SteveLauC SteveLauC deleted the fix/bazzite branch February 17, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topgrade executes dnf on rpm-ostree based Bazzite
2 participants