fix: uBlue OS should be detected as FedoraImmutable #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmutable Instead match `ID=fedora` or `ID_LIKE=fedora` and decide wether or not the distro is immutable by `VARIANT`.
The `os_release`s came from the following images: - ghcr.io/ublue-os/aurora:93f0fd9f20b3 - ghcr.io/ublue-os/bluefin:5d37394a5d4b - ghcr.io/ublue-os/ucore:63cd1200c344
7 tasks
SteveLauC
approved these changes
Feb 17, 2025
|
Thanks |
|
It's no problem. I really enjoy using topgrade as my updater on NixOS and uBlue. But I personally encountered this issue on Aurora, so I figured I'd fix it for myself as well 😆 . I also have a feature I'd like to see for NixOS, so I guess I'll be making an issue for that as well. I'll see if I can implement it myself though, shouldn't be too difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDs for Fedora ImmutableCloses: #1033
What does this PR do
It does what #1034 does but refactored to work in general for any fork of
a Fedora immutable desktop. Thanks to @SteveLauC for their initial work on this
issue. I included their commit as well, because their test case came in handy.
Standards checklist
CONTRIBUTING.mdFor new steps
--dry-runoption works with this step--yesoption works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.