Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oh-my-zsh step issue #646 #647

Merged
merged 6 commits into from
Jan 22, 2024
Merged

fix: oh-my-zsh step issue #646 #647

merged 6 commits into from
Jan 22, 2024

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

This PR fixes #646 by using the script provided by @romkatv, I am not entirely sure about the root cause of that issue, but obviously, the new script is better, so let's use it instead, thanks for your help:)

@SteveLauC
Copy link
Member Author

@lbonvarl, here is a build of this commit, you can give it a test:)

Copy link

@lbonvarl lbonvarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ARM64 Debian 12 via SSH. fix works

@SteveLauC
Copy link
Member Author

tested on ARM64 Debian 12 via SSH. fix works

Thanks!

@SteveLauC SteveLauC merged commit bf72d7b into topgrade-rs:main Jan 22, 2024
7 checks passed
@SteveLauC SteveLauC deleted the omz branch January 22, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topgrade v13.0.0 Z4H SSH issue
3 participants