Repository navigation
Refresh source fields by model attribute name - #2335
Merged
waketzheng merged 5 commits intoOct 23, 2026
Merged
Conversation
5 tasks done
Merging this PR will not alter performance1 warning
Comparing |
waketzheng
approved these changes
Oct 23, 2026
d3vyce
pushed a commit
to d3vyce/tortoise-orm
that referenced
this pull request
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
refresh_from_db()leaving renamed fields stale. With this, full refreshes use model attribute names and update renamed fields and foreign-key IDs correctly.Motivation and Context
Fixes #2334.
How Has This Been Tested?
make checkand 160 focused tests passed. The full SQLite suite passed with 1,984 tests, 149 skips and two expected failures. Four new regression cases fail on the unchanged baseline. PostgreSQL and MySQL were not tested live.Checklist