fix(schematic): render active component alternate display modes - #130
Closed
KrishnaX12 wants to merge 2 commits into
Closed
fix(schematic): render active component alternate display modes#130KrishnaX12 wants to merge 2 commits into
KrishnaX12 wants to merge 2 commits into
Conversation
|
@KrishnaX12 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
KrishnaX12
force-pushed
the
fix/polarized-capacitor-arc
branch
3 times, most recently
from
September 4, 2026 10:32
1810184 to
ee4126d
Compare
KrishnaX12
force-pushed
the
fix/polarized-capacitor-arc
branch
2 times, most recently
from
September 4, 2026 11:19
7b8eac0 to
cf27121
Compare
Contributor
|
no diff? why? |
KrishnaX12
force-pushed
the
fix/polarized-capacitor-arc
branch
from
September 4, 2026 12:54
cf27121 to
d21f960
Compare
KrishnaX12
marked this pull request as draft
September 4, 2026 12:54
KrishnaX12
force-pushed
the
fix/polarized-capacitor-arc
branch
from
September 4, 2026 12:57
d21f960 to
cf27121
Compare
KrishnaX12
force-pushed
the
fix/polarized-capacitor-arc
branch
from
September 4, 2026 13:11
cf27121 to
c69439a
Compare
KrishnaX12
marked this pull request as ready for review
September 4, 2026 13:12
Contributor
Author
threw this fix pr instead of repro |
Contributor
Author
|
@ShiboSoftwareDev Was #130 closed intentionally? |
Contributor
Author
|
Ig, it's auto closed via #131 ??? |
Contributor
|
don't add a repro and a fix in the same pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
DISPLAYMODEwhen rendering owned primitives.Root cause
The schematic record filter only rendered primitives whose
OWNERPARTDISPLAYMODEwas absent or zero. It did not compare owned primitives with the parent component's active display mode.Before vs After
Testing
schematic-component-value-reference.test.ts.