Skip to content

fix(schematic): render active component alternate display modes - #130

Closed
KrishnaX12 wants to merge 2 commits into
tscircuit:mainfrom
KrishnaX12:fix/polarized-capacitor-arc
Closed

fix(schematic): render active component alternate display modes#130
KrishnaX12 wants to merge 2 commits into
tscircuit:mainfrom
KrishnaX12:fix/polarized-capacitor-arc

Conversation

@KrishnaX12

@KrishnaX12 KrishnaX12 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Respect each schematic component's active DISPLAYMODE when rendering owned primitives.
  • Render alternate representations such as polarized-capacitor curved plates instead of mode-0 primitives.
  • Update the full-sheet real-board snapshot introduced by repro(svg): real board ignores active component display modes #131 to show the corrected geometry.

Root cause

The schematic record filter only rendered primitives whose OWNERPARTDISPLAYMODE was absent or zero. It did not compare owned primitives with the parent component's active display mode.

Before vs After

Before After
Before After

Testing

  • All 123 SVG tests pass.
  • Typecheck, formatting, package build, and lint pass.
  • Lint retains one pre-existing warning in schematic-component-value-reference.test.ts.

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

@KrishnaX12 is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

@KrishnaX12
KrishnaX12 force-pushed the fix/polarized-capacitor-arc branch 3 times, most recently from 1810184 to ee4126d Compare September 4, 2026 10:32
@KrishnaX12 KrishnaX12 changed the title fix(schematic): render polarized capacitor arc plates fix(schematic): render active component alternate display modes Sep 4, 2026
@KrishnaX12
KrishnaX12 force-pushed the fix/polarized-capacitor-arc branch 2 times, most recently from 7b8eac0 to cf27121 Compare September 4, 2026 11:19
@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

no diff? why?

@KrishnaX12
KrishnaX12 force-pushed the fix/polarized-capacitor-arc branch from cf27121 to d21f960 Compare September 4, 2026 12:54
@KrishnaX12
KrishnaX12 marked this pull request as draft September 4, 2026 12:54
@KrishnaX12
KrishnaX12 force-pushed the fix/polarized-capacitor-arc branch from d21f960 to cf27121 Compare September 4, 2026 12:57
@KrishnaX12
KrishnaX12 force-pushed the fix/polarized-capacitor-arc branch from cf27121 to c69439a Compare September 4, 2026 13:11
@KrishnaX12
KrishnaX12 marked this pull request as ready for review September 4, 2026 13:12
@KrishnaX12

Copy link
Copy Markdown
Contributor Author

no diff? why?

threw this fix pr instead of repro
jus my bad

@KrishnaX12

Copy link
Copy Markdown
Contributor Author

@ShiboSoftwareDev Was #130 closed intentionally?

@KrishnaX12

Copy link
Copy Markdown
Contributor Author

Ig, it's auto closed via #131 ???
image

@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

don't add a repro and a fix in the same pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants