repro(svg): real board ignores active component display modes - #131
Merged
ShiboSoftwareDev merged 1 commit intoSep 4, 2026
Merged
Conversation
|
@KrishnaX12 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
ShiboSoftwareDev
approved these changes
Sep 4, 2026
Collaborator
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The schematic SVG renderer ignores a component's active
DISPLAYMODEwhen selecting component-owned primitives.In the power schematic used here, ten polarized capacitors have
DISPLAYMODE = 1. Altium 365 renders their lower plates as curves, but altiumts renders the inactive mode-0 flat plates.Real-board reproduction
This PR adds the unmodified, MIT-licensed
AmirhosseinR/Altium_DSP_FPGApower schematic as a pinned reference:61e66e61a6b7fbcfbc370a0b756b2958f38ad493a0e51aeb708bcb7d8f444073a16e5edf9e8aee63ce28329122942ca27150373fThe original schematic naturally contains ten
Cap Pol3components using display mode 1. Each contains mode-1 arc records for the curved polarized-capacitor plate.The test does not modify or crop the source schematic. It verifies those real binary records and records the current broken full-sheet SVG snapshot.
Visual Comparison
Expected behavior
The renderer should select each component's active display-mode primitives, producing curved lower plates for all ten polarized capacitors, matching Altium 365.
Follow-up fix: #130