feat: compose Q10 maps in a pure renderer - #2
Closed
tubededentifrice wants to merge 3 commits into
Closed
Conversation
tubededentifrice
force-pushed
the
agent/q10-map-renderer
branch
2 times, most recently
from
July 19, 2026 16:24
a924f7a to
50d92a9
Compare
tubededentifrice
changed the base branch from
agent/q10-map-decoding
to
agent/q10-map-review-cleanups
July 19, 2026 16:26
tubededentifrice
force-pushed
the
agent/q10-map-renderer
branch
from
July 19, 2026 16:45
50d92a9 to
303fe71
Compare
Owner
Author
|
Superseded by the clean upstream PR Python-roborock#885 now that Python-roborock#884 has merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second PR in the Python-roborock#848 split: adds the pure Q10 map-composition layer on top of the review-cleanup branch.
The cleanup base is proposed upstream as Python-roborock#884. This fork-local stacked PR keeps the incremental diff reviewable while that cross-fork base is pending; it can be promoted upstream as soon as Python-roborock#884 lands.
Changes
Q10MapRender, a replace-whole result containing image bytes,MapData, layers, rooms, and calibration.Q10MapPacket.layersas the renderer boundary introduced by refactor(map): address Q10 decoding review feedback Python-roborock/python-roborock#884.This PR intentionally contains no device-trait or subscription orchestration changes.
Validation
pytest -q tests/map/test_b01_q10_render.py tests/map/test_b01_q10_map_parser.py tests/map/test_b01_grid_layers.py tests/map/test_b01_q10_overlays.py— 74 passedpytest -q— 791 passed, 86 snapshots passedpre-commit run --show-diff-on-failure --color=always --all-filesStack