Skip to content

feat: compose Q10 maps in a pure renderer - #2

Closed
tubededentifrice wants to merge 3 commits into
agent/q10-map-review-cleanupsfrom
agent/q10-map-renderer
Closed

feat: compose Q10 maps in a pure renderer#2
tubededentifrice wants to merge 3 commits into
agent/q10-map-review-cleanupsfrom
agent/q10-map-renderer

Conversation

@tubededentifrice

@tubededentifrice tubededentifrice commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

Second PR in the Python-roborock#848 split: adds the pure Q10 map-composition layer on top of the review-cleanup branch.

The cleanup base is proposed upstream as Python-roborock#884. This fork-local stacked PR keeps the incremental diff reviewable while that cross-fork base is pending; it can be promoted upstream as soon as Python-roborock#884 lands.

Changes

  • Add Q10MapRender, a replace-whole result containing image bytes, MapData, layers, rooms, and calibration.
  • Use Q10MapPacket.layers as the renderer boundary introduced by refactor(map): address Q10 decoding review feedback Python-roborock/python-roborock#884.
  • Keep calibration solving, erase application, path/position placement, vector-overlay placement, and drawing out of device traits.
  • Cover the composition and geometry behavior directly in map-module tests.

This PR intentionally contains no device-trait or subscription orchestration changes.

Validation

  • pytest -q tests/map/test_b01_q10_render.py tests/map/test_b01_q10_map_parser.py tests/map/test_b01_grid_layers.py tests/map/test_b01_q10_overlays.py — 74 passed
  • pytest -q — 791 passed, 86 snapshots passed
  • pre-commit run --show-diff-on-failure --color=always --all-files

Stack

  1. refactor(map): address Q10 decoding review feedback Python-roborock/python-roborock#884 — follow-up review cleanup
  2. This PR — pure renderer
  3. Trait ownership and API integration

@tubededentifrice
tubededentifrice force-pushed the agent/q10-map-renderer branch 2 times, most recently from a924f7a to 50d92a9 Compare July 19, 2026 16:24
@tubededentifrice
tubededentifrice changed the base branch from agent/q10-map-decoding to agent/q10-map-review-cleanups July 19, 2026 16:26
@tubededentifrice
tubededentifrice force-pushed the agent/q10-map-renderer branch from 50d92a9 to 303fe71 Compare July 19, 2026 16:45

Copy link
Copy Markdown
Owner Author

Superseded by the clean upstream PR Python-roborock#885 now that Python-roborock#884 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants