fix(tgbdiff): propagate DepsCSR error from buildReverseCSR - #282
Merged
Conversation
buildReverseCSR silently swallowed DepsCSR errors and returned an empty reverse adjacency, causing the BFS to produce distance -1 for all non-seed targets without any error signal to the caller. Propagate the error so compareInternal fails explicitly on a corrupt deps column.
sywhang
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildReverseCSRsilently swallowedDepsCSRerrors and returned an empty reverse adjacency, causing the BFS to produce distance -1 for all non-seed targets with no error signal to the caller.compareInternalfails explicitly on a corrupt deps column instead of returning silently wrong distances.Test plan
CI