Skip to content

fix(tgbdiff): propagate DepsCSR error from buildReverseCSR #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xytan0056 merged 2 commits into from
Aug 14, 2026
+7 −4
Merged

fix(tgbdiff): propagate DepsCSR error from buildReverseCSR #282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97dacea
fix(tgbdiff): propagate DepsCSR error from buildReverseCSR
xytan0056 Aug 13, 2026
31c52de
fix(tgbdiff): restore DepsCSR rationale comment in buildReverseCSR
xytan0056 Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions internal/tgbdiff/compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,10 @@ func compareInternal(ctx context.Context, before, after *tgb.Reader, opts Option
t3 := time.Now()
nAfter := nAfterNodes
var csrDepBuf []int32
csrOffsets, csrTargets := buildReverseCSR(after, nAfter, &csrDepBuf)
csrOffsets, csrTargets, err := buildReverseCSR(after, nAfter, &csrDepBuf)
if err != nil {
return nil, phases, cnt, err
}
phases.ReverseCSR = time.Since(t3)

// ── Phase 3b: BFS ────────────────────────────────────────────────────────
Expand Down Expand Up @@ -926,13 +929,13 @@ func attrsChanged(before, after map[string]string) bool {
// targets[offsets[i]:offsets[i+1]].
//
// depBuf is a scratch buffer reused across calls to avoid allocation.
func buildReverseCSR(after *tgb.Reader, n int, depBuf *[]int32) (offsets []int32, targets []int32) {
func buildReverseCSR(after *tgb.Reader, n int, depBuf *[]int32) (offsets []int32, targets []int32, err error) {
// Decode the forward edges once into CSR form. Calling Deps per node walks
// the reader's offset table twice over and allocates per node; DepsCSR is a
// single sequential pass over the column.
fwdOff, fwdTgt, err := after.DepsCSR()
if err != nil {
return make([]int32, n+1), nil
return nil, nil, err
}

// Pass 1: count in-degrees.
Expand Down Expand Up @@ -967,5 +970,5 @@ func buildReverseCSR(after *tgb.Reader, n int, depBuf *[]int32) (offsets []int32
}
}

return offsets, targets
return offsets, targets, nil
}
Loading