Skip to content

Conversation

zsjiang99
Copy link

@zsjiang99 zsjiang99 commented Nov 2, 2023

Description

Completing the conversion from units to exponential scale.

Related Issue

When running generate_cmos_tech_data.pl with hspice 2017, you may come across an issue where the current values need to be converted into exponential notation with the "e" notation.(#2424)

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@vaughnbetz
Copy link
Contributor

Looks good; thanks. Will merge once CI passes.

@vaughnbetz vaughnbetz closed this Nov 7, 2023
@vaughnbetz
Copy link
Contributor

@

@vaughnbetz vaughnbetz reopened this Nov 7, 2023
@vaughnbetz
Copy link
Contributor

Accidentally hit the close button; reopening.

@vaughnbetz
Copy link
Contributor

The python code needs formatting:
Run 'make format-py' to apply these changes

There are also some spurious Clang-compatibility failures (not sure why they're failing right now, but it is some other issue as they are failing on all PRs).

@vaughnbetz
Copy link
Contributor

Updating to master and re-launching CI to see if the failures are gone. @luck-codeer : if you can format the new python code that would be great so we can land this.

@github-actions github-actions bot added lang-python Python code lang-shell Shell scripts (bash etc.) labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-python Python code lang-shell Shell scripts (bash etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants