Repository navigation
alerting: strike through resolved infra alerts instead of appending a banner - #141
Merged
Merged
Conversation
… banner The edited message now reads as a checkmark-prefixed, struck-through copy of the original alert ending in '(edited)' — the channel reads as handled at a glance and the stale-threshold confusion from rendering the resolve banner against the episode's opening threshold disappears. Signed-off-by: Thang Nguyen <thang.nguyen@inferact.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Follow-up to #140 with the resolved-message look we want: when an infra episode resolves, the bot's open alert is edited into:
— original text struck through, ✅ prefix,
(edited)suffix. The previous composition (original + appended resolve banner) is gone; that also removes the confusing case where the banner quoted the episode's opening threshold rather than the current one.Tests
test_outbox.py: pairing asserts the exact struck-through payloadtest_infra.py: resolve assertions now check the ✅/…/(edited)shapepytest alerting202 passed, ruff cleanDeploy
Worker picks this up on the next
install.shfrommain. Only affects how resolves render.Signed-off-by: Thang Nguyen thang.nguyen@inferact.ai