Repository navigation
ENH: Make Raven format work for BirdNET Live output, fix #301 - #302
Closed
NickleDave wants to merge 2 commits into
Closed
NickleDave wants to merge 2 commits into
NickleDave wants to merge 2 commits into
Conversation
Tell `pandera` to `coerce` the "Low Freq (Hz)" and "High Freq (Hz)" columns to float, instead of raising a SchemaError because those columns are int values. See linked issue for detail.
We're getting a bunch of spurious failures because `pandera` added a `errors.SchemaErrors` plural for the case where multiple rules of a schema fail. This is yet another time where it feels like `pandera` is more trouble than it's worth. What we want is a nice error message explaining something is wrong with the annotation file. What we get is a wall of text that will mean nothing to most users.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 33 33
Lines 1412 1412
=======================================
Hits 1267 1267
Misses 145 145 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Closing since this was addressed by birdnet-team/birdnet-live-app#266 |
NickleDave
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell
panderatocoercethe "Low Freq (Hz)" and "High Freq (Hz)" columns to float, instead of raising a SchemaError because those columns are int values. See comment on #301 for rationale:#301 (comment)