refactor(js-runtime): drop unused async-trait from JsRuntimeProvider - #2538
Open
jong-kyung wants to merge 1 commit into
Open
refactor(js-runtime): drop unused async-trait from JsRuntimeProvider#2538jong-kyung wants to merge 1 commit into
jong-kyung wants to merge 1 commit into
Conversation
The trait has no async methods, so the attribute generated nothing. Remove it and the async-trait dependency from vp_js_runtime.
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsRuntimeProviderwas annotated with#[async_trait], but none of its methods are async.name,platform_string,get_download_info,binary_relative_path,bin_dir_relative_path, andparse_shasumsare all synchronous, so the macro had nothing to transform and generated the same code as the plain trait.If a future runtime provider (Bun, Deno) needs async trait methods, the attribute can be added back at that point.