Skip to content

refactor(js-runtime): drop unused async-trait from JsRuntimeProvider #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 2 commits into from
Aug 24, 2026
Merged

refactor(js-runtime): drop unused async-trait from JsRuntimeProvider #2538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
882e2b7
refactor(js-runtime): drop unused async-trait from JsRuntimeProvider
jong-kyung Aug 23, 2026
b5d63b6
Merge branch 'main' into refactor/js-runtime-drop-async-trait
jong-kyung Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/vp_js_runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ publish = false
rust-version.workspace = true

[dependencies]
async-trait = { workspace = true }
backon = { workspace = true }
flate2 = { workspace = true }
futures-util = { workspace = true }
Expand Down
2 changes: 0 additions & 2 deletions crates/vp_js_runtime/src/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
//! This module defines the trait that all runtime providers (Node, Bun, Deno)
//! must implement, along with types for describing download information.

use async_trait::async_trait;
use vt_str::Str;

use crate::{Error, Platform};
Expand Down Expand Up @@ -77,7 +76,6 @@ pub struct DownloadInfo {
///
/// Each runtime (Node.js, Bun, Deno) implements this trait to provide
/// runtime-specific logic for downloading and installing.
#[async_trait]
pub trait JsRuntimeProvider: Send + Sync {
/// Get the name of this runtime (e.g., "node", "bun", "deno")
fn name(&self) -> &'static str;
Expand Down
2 changes: 0 additions & 2 deletions crates/vp_js_runtime/src/providers/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

use std::time::{SystemTime, UNIX_EPOCH};

use async_trait::async_trait;
use node_semver::{Range, Version};
use serde::{Deserialize, Serialize};
use vt_path::{AbsolutePath, AbsolutePathBuf};
Expand Down Expand Up @@ -590,7 +589,6 @@ fn is_official_dist_host(base_url: &str) -> bool {
host.eq_ignore_ascii_case("nodejs.org")
}

#[async_trait]
impl JsRuntimeProvider for NodeProvider {
fn name(&self) -> &'static str {
"node"
Expand Down
Loading