Open
Conversation
|
This goes well with #79. Hope to see this included as well. 👍 |
|
@al7373 Mind resolving the conflicts? |
mbonneau
requested changes
May 2, 2018
Member
mbonneau
left a comment
mbonneau
left a comment
There was a problem hiding this comment.
This looks good except that it should only set the option if set in the annotation. This also needs to be reworked into the current master branch.
|
|
||
| //Subscribe Options | ||
| $subscribeOptions = [ | ||
| 'disclose_publisher' => $disclosePublisher |
Member
There was a problem hiding this comment.
I would like to see disclose_publisher only set if there is an option set, not for every subscribe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@davidwdan
Here is a proposed fix for Issue #25.
Please let me know if you have any recommended changes.
Thanks,
Alain