Skip to content

Disclose publisher option #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
al7373 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disclose publisher option #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0af540e
Add getDisclosePublisher function
al7373 Jan 12, 2018
1b5c88a
Add subscribeOptions array
al7373 Jan 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Voryx/ThruwayBundle/Annotation/Subscribe.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ class Subscribe implements AnnotationInterface
*/
protected $value;

protected $disclosePublisher;

protected $serializerGroups;

protected $serializerEnableMaxDepthChecks;
Expand Down Expand Up @@ -50,6 +52,14 @@ public function getName()
return $this->value;
}

/**
* @return mixed
*/
public function getDisclosePublisher()
{
return $this->disclosePublisher;
}

/**
* @return mixed
*/
Expand Down
12 changes: 10 additions & 2 deletions src/Voryx/ThruwayBundle/WampKernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,14 +228,22 @@ public function handleRPC($args, $argsKw, $details, MappingInterface $mapping)
*/
protected function createSubscribe(MappingInterface $mapping)
{
$topic = $mapping->getAnnotation()->getName();
/* @var $annotation Subscribe */
$annotation = $mapping->getAnnotation();
$disclosePublisher = $annotation->getDisclosePublisher() !== null ? $annotation->getDisclosePublisher() : true;
$topic = $annotation->getName();

//Subscribe Options
$subscribeOptions = [
'disclose_publisher' => $disclosePublisher
Copy link
Member

@mbonneau mbonneau May 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see disclose_publisher only set if there is an option set, not for every subscribe.

];

$subscribeCallback = function ($args, $argsKw, $details) use ($mapping) {
$this->handleEvent($args, $argsKw, $details, $mapping);
};

//Subscribe to a topic
$this->session->subscribe($topic, $subscribeCallback);
$this->session->subscribe($topic, $subscribeCallback, $subscribeOptions);
}

/**
Expand Down