-
Notifications
You must be signed in to change notification settings - Fork 389
Infrastructure: Update link-checker
User-Agent string
#3264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
link-checker
User-Agent string
link-checker
User-Agent stringlink-checker
User-Agent string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good enough, and will fix the bug in the short term, but will probably break again in a few months.
I did a little research and ran into https://www.npmjs.com/package/user-agents - a package that someone has automated to collect the most popular user agents used on their own websites and it can generate "always up to date" user agents. We may want to look into using this package instead.
After a bit more research and a comment from @howard-e - https://github.com/DavideViolante/useragents-me-api/ looks like a much better choice
Given this is infra, I was waiting on you to merge. |
Certainly true.
Not so much a fan for adding an extra lib for this small use case. Agreed on making this more future-proof, with the hardcoded string as a fallback. Fetching from the source site of that lib (specifically https://www.useragents.me/#most-common-desktop-useragents) is a good enough option to do in the future, to move this PR along. Edit: tracking this in #3270 |
A string of failures on this makes me think this solution is flaky in other areas, particularly with GitHub links. So something to investigate separately as well. 6 failures after my last commit for the following links:
expand for list of failing builds
|
Fix #3263
WAI Preview Link (Last built on Tue, 20 May 2025 13:59:09 GMT).