Skip to content

Conversation

bjohansebas
Copy link

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

While with Express there are hardly any changes other than adding support for some encodings or changing the regex path match, so nothing in the Express code will change for now. However, it is necessary to update http-proxy-middleware, since in version 2 they have a resolution to use Express 4, whereas version 3 of that package already allows a different version of Express and other packages. :)

Signed-off-by: Sebastian Beltran <[email protected]>
Signed-off-by: Sebastian Beltran <[email protected]>
@bjohansebas
Copy link
Author

I still need to investigate why some content-types are not being changed, since JavaScript files are now "text/javascript", but somewhere that content-type is still not being updated, and also run the allowed-host tests.

@alexander-akait
Copy link
Member

I still need to investigate why some content-types are not being changed, since JavaScript files are now "text/javascript", but somewhere that content-type is still not being updated, and also run the allowed-host tests.

Can you provide where?

It can be a problem in webpack-dev-middleware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants